#13826: Race condition in star_imports cache
--------------------------------+-------------------------------------------
       Reporter:  vbraun        |         Owner:  GeorgSWeber
           Type:  defect        |        Status:  needs_work 
       Priority:  critical      |     Milestone:  sage-5.5   
      Component:  build         |    Resolution:             
       Keywords:                |   Work issues:             
Report Upstream:  N/A           |     Reviewers:  Nils Bruin 
        Authors:  Volker Braun  |     Merged in:             
   Dependencies:                |      Stopgaps:             
--------------------------------+-------------------------------------------
Changes (by nbruin):

  * status:  positive_review => needs_work


Comment:

 OK, it seems the issues I pointed out are a little less straightforward
 than I thought, so they should probably be cleared up before this ticket
 gets merged.

 > So? Go ahead and design a workflow that takes care of it automatically
 if it bothers you.

 It's a space after a colon on a line you introduce, not some whitespace on
 an empty line left by an auto-indenting editor.

 > Because os.rename() will fail if the destination exists on Windows
 (thanks for the well-thought out filesystem semantics, Bill G.!)

 That's not what I meant. You can first write the temp file and then unlink
 the old one and move the new one in place. Presently the old cache file is
 already gone while you're writing the new one. An old cache file is better
 than none at all, it seems in this setting?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13826#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to