#13826: Race condition in star_imports cache
--------------------------------+-------------------------------------------
       Reporter:  vbraun        |         Owner:  GeorgSWeber    
           Type:  defect        |        Status:  positive_review
       Priority:  critical      |     Milestone:  sage-5.5       
      Component:  build         |    Resolution:                 
       Keywords:                |   Work issues:                 
Report Upstream:  N/A           |     Reviewers:  Nils Bruin     
        Authors:  Volker Braun  |     Merged in:                 
   Dependencies:                |      Stopgaps:                 
--------------------------------+-------------------------------------------
Changes (by nbruin):

  * status:  needs_review => positive_review
  * reviewer:  => Nils Bruin


Comment:

 Looks good to me (mostly). Few small issues:
  - whitespace plugin complains about introduced whitespace
  - the code writing the cache file first deletes the cachefile, writes the
 new one in a temporary file, and then moves it in place. Why not leave the
 old cache file in place while the new one gets written?
 I'm setting review to positive anyway.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13826#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to