#13814: LazyFamily.__eq__ gives false positives.
------------------------------------+---------------------------------------
Reporter: cnassau | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Christian Nassau | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Comment (by cnassau):
I have implemented a new patch, based on Sage 5.5.rc0. Here are the key
features:
The new {{{LazyFamily.__eq__}}}
* does not compare function values (even if the indexing set is finite)
* recognizes identical function objects
* uses {{{self.function.__eq__}}} if this is available
* otherwise treats functions as distinct
Furthermore
* "{{{f != g}}}" is exactly equivalent to "{{{not(f==g)}}}"
Contrary to my expectations there were not that many doctest failures. The
only affectes files were ``family.py`` and
``disjoint_union_enumerated_sets.py``.
Originally I was hoping to present two patches, plus numbers/statistics
about doctest failures and the like.... but I'm a little bit too
exhausted right now. And I think the new patch is probably good enough as
it stands ;-)
Cheers, \\
Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13814#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.