#13814: LazyFamily.__eq__ gives false positives.
------------------------------------+---------------------------------------
       Reporter:  cnassau           |         Owner:  sage-combinat
           Type:  defect            |        Status:  needs_review 
       Priority:  major             |     Milestone:  sage-5.6     
      Component:  combinatorics     |    Resolution:               
       Keywords:                    |   Work issues:               
Report Upstream:  N/A               |     Reviewers:               
        Authors:  Christian Nassau  |     Merged in:               
   Dependencies:                    |      Stopgaps:               
------------------------------------+---------------------------------------

Comment (by nthiery):

 Replying to [comment:2 cnassau]:
 > The TestSuite failures would probably be fixed if `_test_pickling` would
 check for
 >    {{{
 >    not (f != loads(dumps(f)))
 >    }}}
 > rather than
 >    {{{
 >    f == loads(dumps(f))
 >    }}}
 > I'll suggest this in a different ticket.

 ``__eq__`` and ``__ne__`` are supposed to be implemented consistently; so
 _test_pickling is allowed to rely on this assumption. If the
 assumption fails, that's an equality bug which should be fixed in
 ``__eq__/__ne__`` and be tested in ``_test_equal`` (whenever possible).

 Cheers,
                    Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13814#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to