#13162: add experimental libfes package
----------------------------------------+-----------------------------------
       Reporter:  Bouillaguet           |         Owner:  malb           
           Type:  enhancement           |        Status:  needs_work     
       Priority:  major                 |     Milestone:  sage-5.6       
      Component:  experimental package  |    Resolution:                 
       Keywords:                        |   Work issues:                 
Report Upstream:  N/A                   |     Reviewers:  Martin Albrecht
        Authors:  Charles Bouillaguet   |     Merged in:                 
   Dependencies:  #13202                |      Stopgaps:                 
----------------------------------------+-----------------------------------
Changes (by malb):

  * status:  needs_review => needs_work


Comment:

 Hi Charles, sorry being so late in my reply:

  * line 2: Sage is spelled Sage not SAGE, in fact "Binding for the FES
 library" should be sufficient, that this is for Sage is kind of obvious
  * You define exhaustive_search as !{{{cpdef}}} but you don't specify
 input and output types, defeating the purpose of having it callable from C
  * If it that function ought to be a Python function then perhaps max_sols
 should accept infinity as a parameter for "no restriction". It's what the
 SAT solver interface in Sage does.
  * I'd swap !{{{verbose}}} and !{{{max_sols}}} because !{{{max_sols}}}
 changes the behaviour in a more fundamental way than !{{{verbose}}}.
  * One can also specify verbosity with !{{{set_verbose}}}, if you like
 !{{{verbose}}} as a parameter better for some reason, no strict need to
 change it, most people don't use !{{{set/get_verbose}}} in their code it
 seems.
  * "The order in which the solutions are returned is implementation
 dependent" if that's the case, then the doctests need to take that into
 account, i.e., they have the order hard coded at the moment. You could run
 sorted() on the output (in the doctests)
  * You can run PLE decomposition on your matrix (see
 sage.matrix.matrix_mod2_dense) which is a generalisation of LU and is very
 fast because it's implemented in M4RI
  * Isn't there some restriction for the number of variables?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13162#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to