#13821: Change sage.combinat.combinat.combinations() to use Combinations
-----------------------------------------+----------------------------------
Reporter: ppurka | Owner: sage-combinat
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.6
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Travis Scrimshaw
Authors: Punarbasu Purkayastha | Merged in:
Dependencies: #13723, #11763 | Stopgaps:
-----------------------------------------+----------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
Comment:
Works for me as well:
{{{
travis@travis-virtualbox:~/sage-5.5.rc0/devel/sage-reviews/sage$ sage -t
graphs/generic_graph.py geometry/polyhedron/base_ZZ.py
sage -t "devel/sage-reviews/sage/geometry/polyhedron/base_ZZ.py"
[24.3 s]
sage -t "devel/sage-reviews/sage/graphs/generic_graph.py"
[91.9 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 116.3 seconds
}}}
(For whomever is interested, the replace patch depends on #13503)
I've had this issue of the patchbot using old patches come up a few places
before. I've kicked the patchbot, so hopefully next time the patchbot will
pass all tests. Since the tests pass for me, I'm going to set this to
positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13821#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
