#13899: Don't use TAB characters for indentation
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: jason
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-5.6
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Leif Leonhardy, Karl-Dieter
Crisman
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by kcrisman):
* reviewer: Leif Leonhardy => Leif Leonhardy, Karl-Dieter Crisman
Old description:
> * TABs in Makefiles are needed, so keep them.
> * Some TABs not used for indentation are also kept.
> * TABs in the obsolete directory `devel/sage/sage/server/notebook`
> (#11409) are not fixed.
> * The directory `sage/graphs/planarity_c` uses a very inconsistent
> indentation scheme (mixing spaces and TABs and having varying amounts of
> indentation) is hopeless to easily fix automatically.
> * Also, make indentation consistent and/or remove trailing spaces in some
> places.
>
> The release manager script has been updated to check all new patches for
> added TAB indentation.
>
> Apply:
> * [attachment:13899_TAB_sage_root.patch] to the root repository
> * [attachment:13899_TAB_sagelib.patch] and [attachment:trac_13899
> -doctest-rebase.patch] to the Sage library
> * [attachment:13899_TAB_scripts.patch] to the scripts repository
New description:
* TABs in Makefiles are needed, so keep them.
* Some TABs not used for indentation are also kept.
* TABs in the obsolete directory `devel/sage/sage/server/notebook`
(#11409) are not fixed.
* The directory `sage/graphs/planarity_c` uses a very inconsistent
indentation scheme (mixing spaces and TABs and having varying amounts of
indentation) is hopeless to easily fix automatically.
* Also, make indentation consistent and/or remove trailing spaces in some
places.
The release manager script has been updated to check all new patches for
added TAB indentation.
Apply:
* [attachment:13899_TAB_sage_root.patch] to the root repository
* [attachment:13899_TAB_sagelib.patch] and
[attachment:13899_doctest.patch] to the Sage library
* [attachment:13899_TAB_scripts.patch] to the scripts repository
--
Comment:
Patchbot, apply 13899_TAB_sage_root.patch] to the root repository,
13899_TAB_sagelib.patch and 13899_doctest.patch to the Sage library, and
13899_TAB_scripts.patch to the scripts repository.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13899#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
