#13916: Fix inspection of interactive Cython code
------------------------------+---------------------------------------------
Reporter: SimonKing | Owner: jason
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: | Stopgaps:
------------------------------+---------------------------------------------
Comment (by SimonKing):
Replying to [comment:5 Snark]:
> 2. but shouldn't os.path.join(SAGE_ROOT,'devel/sage', raw_filename) be
os.path.join(SAGE_ROOT, 'devel', 'sage', raw_filename)? You're basically
assuming that '/' is the path separator, which is perhaps a portability
problem.
Yes, you are right. I'll update the patch in a minute.
> On the box where I patched paths, the source file looks like this:
> {{{
>
> include "sage/ext/stdsage.pxi" # ctrl-c interrupt block support
>
> include "cdefs.pxi"
> cpdef test_funct(x,y): return
> }}}
>
> while on another, unpatched, box (again, initial empty line is eaten by
trac) it is:
> {{{
> include "interrupt.pxi" # ctrl-c interrupt block support
> include "stdsage.pxi" # ctrl-c interrupt block support
>
> include "cdefs.pxi"
> cpdef test_funct(x,y): return
> }}}
OK. That explains why the line number has changed, because the number of
lines in front of the function definition has changed. And I suppose the
change is indeed related with your patch from #12728, isn't it?
The patch from here is self-contained, but one old test and the new test
from here will change with #12728. Hence, I suggest to use this ticket as
a new dependency for #12728, and you add a patch on #12728 that fixes the
doctests.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13916#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
