#13922: Avoid a regression in the creation of homsets
-------------------------------+--------------------------------------------
       Reporter:  SimonKing    |         Owner:  tbd         
           Type:  defect       |        Status:  needs_review
       Priority:  critical     |     Milestone:  sage-5.6    
      Component:  performance  |    Resolution:              
       Keywords:               |   Work issues:              
Report Upstream:  N/A          |     Reviewers:              
        Authors:  Simon King   |     Merged in:              
   Dependencies:  #715         |      Stopgaps:              
-------------------------------+--------------------------------------------

Comment (by SimonKing):

 Replying to [comment:18 nbruin]:
 > Not introduced by this patch, so shouldn't be held against it, but ...
 > {{{
 > RealIntervalField_cache = {}
 > }}}
 > Is a strong cache!

 Yes. And since `RealIntervalField` is a very simple function (taking just
 one integer and one bool as argument), I would actually suggest to let
 `RealIntervalField_class` inherit from `UniqueRepresentation` and make
 `RealIntervalField` and alias for `RealIntervalField_class`. The point is
 that `UniqueRepresentation` will soonish have a weak cache (namely: If all
 the problems with #715 and #11521 are sorted out). See #12215.

 The questions are:

 1. Do we want to the change from a custom constructor function to
 `UniqueRepresentation`?
 2. Do we want to change it ''here'', or shall we have a quick fix for now
 and do it properly on a different ticket?

 I expect that it would be relatively harmless to use
 `UniqueRepresentation` in this case. Shall I try?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13922#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to