#12418: adding Delsarte bound for codes
----------------------------------+-----------------------------------------
       Reporter:  dimpase         |         Owner:  wdj         
           Type:  enhancement     |        Status:  needs_review
       Priority:  major           |     Milestone:  sage-5.6    
      Component:  coding theory   |    Resolution:              
       Keywords:                  |   Work issues:              
Report Upstream:  N/A             |     Reviewers:              
        Authors:                  |     Merged in:              
   Dependencies:  #12533, #13650  |      Stopgaps:              
----------------------------------+-----------------------------------------

Comment (by ppurka):

 Thanks for the update. I have some general comments. Will look into this
 patch in more detail too.
 1. There are lot of trailing whitespaces. The patchbot will complain. :)
 2. What is the point of this portion of the code? Can't it be replaced by
 `kk = ZZ(log(q, q_base))`?
 {{{#!python
    kk = 0
    while q_base**kk < q:
       kk += 1
 }}}
 3. There is another bit further down:
 {{{
       m = -1
       while q_base**(m+1) < bd:
         m += 1
       if q_base**(m+1) == bd:
         m += 1
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12418#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to