#12418: adding Delsarte bound for codes
----------------------------------+-----------------------------------------
Reporter: dimpase | Owner: wdj
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: coding theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: #12533, #13650 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by dimpase):
Replying to [comment:24 ppurka]:
> Thanks for the update. I have some general comments. Will look into this
patch in more detail too.
> 1. There are lot of trailing whitespaces. The patchbot will complain. :)
I've just uploaded an update with all the trailing spaces removed.
> 2. What is the point of this portion of the code? Can't it be replaced
by `kk = ZZ(log(q, q_base))`?
> {{{#!python
> kk = 0
> while q_base**kk < q:
> kk += 1
> }}}
> 3. There is another bit further down:
> {{{#!python
> m = -1
> while q_base**(m+1) < bd:
> m += 1
> if q_base**(m+1) == bd:
> m += 1
> }}}
this came from an older piece of plain Python. Then I struggled with log()
quite a bit, and finally gave up on it and rolled my own.
> 4. Also, I don't think this deprecation is necessary any more. The
ticket you cited is over 2 years old.
> {{{#!diff
> -def dimension_upper_bound(n,d,q):
> +@rename_keyword(deprecation=6094, method="algorithm")
> +def dimension_upper_bound(n,d,q,algorithm=None):
> }}}
I blindly copied from {{{sage/coding/code_bounds.py}}}
Should the whole file be cleaned out of these?
By the way, plural {{{methods}}} slipped through this decorator...
>
> '''Edit:''' Sorry. It seems `ZZ` doesn't work but `int(log(..))` does
work.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12418#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
