#4667: [with patch, needs review] quadratic twists for p-adic L-functions
---------------------------+------------------------------------------------
Reporter: wuthrich | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.2
Component: number theory | Keywords: padic l-functions, quadratic twists
---------------------------+------------------------------------------------
Comment(by GeorgSWeber):
There are two aspects to be considered with a patch of this kind:
- The technical one (is the code correctly merged into the system, or are
regressions introduced?). In this area of Sage I would trust the doctests,
especially John has added valuable ones that should cover enough cases so
regressions are caught. As was exactly the case, BTW! A reviewer has to
have an eye on the new code in this regard, too --- would the new doctests
show regressions possibly introduced later? (Let's say some erronuous
future patch to the core code of the p-adic numbers?) I did covince myself
of that two months ago, but would like to look into it again now. And
alas, I seem to desparately need the oncoming two weeks Easter vacation
(where I will have no Internet access at all).
- The theoretical one (do the mathematics make sense, are the
normalizations reasonable, and such?) In this regard, the patch of Chris
is an absolute win for Sage. The original p-adic L-series code of William
was OK, and it was good to have that code in Sage at all. But the
reworkings of Chris are certainly enhancements heading in the right
direction --- William?
I certainly want to make Michael's (the integrator's) life easier, not
harder. And from the experience yesterday I don't trust myself right now
(it's again only 10 minutes before midnight). So either the review has to
wait for, say, another month or so, or a new reviewer steps in. William,
John?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4667#comment:18>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
