#13836: Fix variable dependence in PiecewisePolynomial
----------------------------------------------+-----------------------------
Reporter: christiankuper | Owner: burcin
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.6
Component: symbolics | Resolution:
Keywords: Piecewise, critical_points | Work issues:
Report Upstream: N/A | Reviewers: Burcin Erocal
Authors: Andrew Fleckenstein | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------+-----------------------------
Comment (by afleckenstein):
Replying to [comment:17 christiankuper]:
> Hello Andrew,
>
> I think there is still a small inconsistency in your code: In most
methods you use the default_variable as the parameter. However, in
critical_points() you just deleted old asignment of using "x" as the
variable. While the other methods work with expressions with more than
variable, critical_points() raises a TypeError.
>
> What would be even nicer than using the default_variable IMHO would be
the use of the "var" parameter in the constructor (if defined). What do
yout think? Or maybe this would be something for a nother patch.
>
> Christian
I fixed the critical_points inconsistency, thank you for pointing that
out. As for the default_variable(), I was just using what was already
written for the purpose, I think it's rather helpful. If var is undefined,
we have to end up using default_variable() anyway, so IMHO it would be
better to keep it a little simpler.
Andrew
P.S., I fixed a small grammatical error in the docstring for
default_variable().
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13836#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
