#13605: Partition options and cleanup partitions documentation
-----------------------------------------------+----------------------------
       Reporter:  tscrim                       |         Owner:  sage-combinat
           Type:  enhancement                  |        Status:  needs_review 
       Priority:  major                        |     Milestone:  sage-5.7     
      Component:  combinatorics                |    Resolution:               
       Keywords:  partition, options, output   |   Work issues:               
Report Upstream:  N/A                          |     Reviewers:  Andew Mathas 
        Authors:  Travis Scrimshaw             |     Merged in:               
   Dependencies:  #13074 #13762 #13840 #10193  |      Stopgaps:               
-----------------------------------------------+----------------------------

Comment (by andrew.mathas):

 In response to Simon, the main bottleneck at the moment is the glacial
 pace of my reviewing. I will try get through this more quickly. In any
 case, I think that Travis and I will get the chance to sort this out face-
 to-face in ICERM in about two weeks so the patch should get a positive
 review by mid February at the latest.


 Replying to [comment:17 tscrim]:
 >
 > End of the day, I'm really starting to think that deciding an ordering
 is more trouble than it's worth. At the very least, given #13991, should
 we separate this feature out to another ticket?

 In spite of misgivings (maybe this is too strong!:) about the orders, I
 haven't yet found a way to do this that I am more comfortable with.
 Certainly one aspect that I don't like about the current implementation is
 that by having the option checking inside __lt__ etc I am worried that
 this will have a significant cost when sorting a large number of
 partitions (I need to profile and check). If the orderings were made into
 a separate ticket this would definitely speed things up -- and I would
 volunteer to review the extra ticket.

 > Last thing for now, are there any other major issues currently with this
 patch? I really appreciate you reviewing this.

 No, nothing major. So far just a few missing bits of documentation and
 there's a few conventions that I thought I'd put to the vote on sage-
 combinat. Apart from this, I would prefer that there was a more generic
 way to take care of the class options but if this ever does come into
 existence then what you have done could easily be rebased on top of it.

 > Edit/PS - I'm back in the US.

 Australia is still in holiday mode:)  A.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13605#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to