#13820: Add the Johnson graph to Sage's constructors
---------------------------------+------------------------------------------
Reporter: slani | Owner: slani
Type: task | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: graph theory | Resolution:
Keywords: Johnson graph | Work issues:
Report Upstream: N/A | Reviewers: Nathann Cohen
Authors: Uros Slana | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
* reviewer: => Nathann Cohen
Old description:
> Hello! This is my first contribution to sage. Its quite trivial since it
> is only meant to test how things work here. Hopefully I'll add something
> more substantial in the near future.
>
> Let me know if the patch is appropriate.
New description:
Hello! This is my first contribution to sage. Its quite trivial since it
is only meant to test how things work here. Hopefully I'll add something
more substantial in the near future.
Let me know if the patch is appropriate.
Apply:
* [attachment:trac_JohnsonGraph_5_6.patch]
* [attachment:trac_13820-rev.patch]
--
Comment:
Helloooooooo again !
Well, your patch looks good indeed, short of a few unimportant things :
* Your paragraphs were a bit too short, the limit in Sage is something
like 80 characters
* It was a good occasion to advertise a Wikipedia page
* There were some trailing whitespaces, and it may hurt some people's
feeling to find these in Sage's code.
This is fixed in a small reviewer's patch that I attach. If you agree with
those changes (and as I agree with yours), then you can set this ticket to
`positive_review`. And thank you for this patch of course `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13820#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
