#5627: [with patch, needs review] Trivial typo in quadratic_nonresidue
-----------------------------+----------------------------------------------
Reporter: kcrisman | Owner: justin
Type: defect | Status: new
Priority: trivial | Milestone: sage-3.4.1
Component: quadratic forms | Keywords:
-----------------------------+----------------------------------------------
Comment(by kcrisman):
Those are very interesting remarks! Unfortunately, I didn't write it, I
just used it, as they say.
What I would say is that you should definitely review this, based of
course on whether it fixes the typo and whether the new error checks and
doctest are wrong (and of course whether it makes performance WORSE, which
is possible since IANAP [I am not a programmer!]).
Then you should open a different ticket for the performance issue and
implement whatever you think is best. (Maybe srange would allow your
other example to work?) I feel like this is what mabshoff would say,
anyway :) I'm not really sure whether this function has non-pedagogical
uses in real life, but it's always worth looking at improvements that
dramatic!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5627#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
