#5627: [with patch, needs review] Trivial typo in quadratic_nonresidue
-----------------------------+----------------------------------------------
Reporter: kcrisman | Owner: justin
Type: defect | Status: new
Priority: trivial | Milestone: sage-3.4.1
Component: quadratic forms | Keywords:
-----------------------------+----------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch {{{quad-nonres.patch}}} applies OK against Sage 3.4.1.alpha0;
all doctests passed with the options
{{{
-t -long
}}}
I'm also adding the patch {{{trac_5627-referee.patch}}} which adds another
test case in addition to kcrisman's test case. This patch should be
applied on top of kcrisman's patch. So positive review for kcrisman's
patch. Only my patch needs to be reviewed.
[[BR]][[BR]]
As for my observation on performance improvement, I agree with kcrisman
that the issue should definitely be addressed in another ticket. That
issue should not prevent kcrisman's patch from being applied, since
kcrisman's patch only deals with exception handling, adding a test case,
and fixing a typo.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5627#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
