#8327: Implement the universal cyclotomic field, using Zumbroich basis
-----------------------------------------------------+----------------------
Reporter: nthiery | Owner:
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.7
Component: number fields | Resolution:
Keywords: Cyclotomic field, Zumbroich basis | Work issues:
Report Upstream: N/A | Reviewers: Frédéric
Chapoton
Authors: Christian Stump, Simon King | Merged in:
Dependencies: #13765 | Stopgaps:
-----------------------------------------------------+----------------------
Changes (by stumpc5):
* status: needs_work => needs_review
Comment:
Replying to [comment:192 jdemeyer]:
> There is a lot of
> {{{
> except:
> }}}
> in the patch.
Thanks for the comment, I fixed this by removing some of the
{{{except}}}'s, and used {{{KeyError}}}'s in two remaining places. I also
fixed a bug, namely
{{{
sage: UCF(0).is_rational()
False
}}}
and added the doctests rechecking this. Since the patchbot doesn't like to
apply #13765 (which was merged in 5.7.beta2), I wonder if you could have
another look and either rebase the patch, or - if you don't plan to merge
it - to wait until I have a new version compiled to rebase it myself.
Thanks, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8327#comment:193>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
