#5513: [with new patch, needs review (again)] Enhanced support for number field
unit groups
---------------------------+------------------------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: number theory | Keywords: number field unit group
---------------------------+------------------------------------------------
Comment(by cremona):
Replying to [comment:22 cremona]:
> ok -- see newest patch (units_rebased3.patch, to replace
units_rebased2.patch).
>
> I took the lazy way out and added #random to all the outputs which
return actual units. It may be a 32/64 issue, but not just that since
when testing this patch on one machine I kept on getting different
generating units out of pari. I seem to remember that there is a way to
"reset" pari in doctests to avoid this random-ness.
>
> Mathematically this is not so unreasonable since any f.g. abelian group
will lots (infinitely many) sets of generators and there is no way to pick
one canonically. (William and I thought about this for elliptic curve
generators and came up against an unsolved problem which prevents this
being possible even in principle!).
Michael,
since all I did here was to add #random to the problem tests, does this
need more review or could it be merged now?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5513#comment:23>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
