#14052: Enabling plotting of top graded piece of infinite dimensional crystals
-----------------------------------------------+----------------------------
Reporter: aschilling | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: combinatorics | Resolution:
Keywords: crystals, digraph, plotting | Work issues:
Report Upstream: N/A | Reviewers: Nicolas M.
Thiery, Travis Scrimshaw
Authors: Anne Schilling | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------------+----------------------------
Changes (by tscrim):
* status: needs_info => needs_review
Comment:
Hey Sebastien,
I agree with you that there needs to be a more comprehensive class rather
than two smaller classes, and I thank you for working on refactoring the
code. However I believe that the depth should be an attribute of the class
rather than an optional argument for an iterator method because these
classes model a (sub)set obtained by (recursive) iteration. I don't know
of any other such feature in sage.
Additionally I believe that just because a class is scheduled to be
deprecated, this is not a reason to incorporate a useful feature or a
short-term fix. I also find this feature helpful for my code (for #13872).
If you want a note that `backtrack.py` will be refactored, I would be fine
with that. However, I would prefer `braktrack.py` to be refactored after
this patch and so I am setting this back to positive review.
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14052#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
