#14052: Enabling plotting of top graded piece of infinite dimensional crystals
-----------------------------------------------+----------------------------
       Reporter:  aschilling                   |         Owner:  sage-combinat  
                    
           Type:  enhancement                  |        Status:  needs_info     
                    
       Priority:  major                        |     Milestone:  sage-5.7       
                    
      Component:  combinatorics                |    Resolution:                 
                    
       Keywords:  crystals, digraph, plotting  |   Work issues:                 
                    
Report Upstream:  N/A                          |     Reviewers:  Nicolas M. 
Thiery, Travis Scrimshaw
        Authors:  Anne Schilling               |     Merged in:                 
                    
   Dependencies:                               |      Stopgaps:                 
                    
-----------------------------------------------+----------------------------
Changes (by slabbe):

  * status:  positive_review => needs_info


Comment:

 Hi Anne,

 I have one small comment about the patch related to the modifications made
 to the file {{{sage/combinat/backtrack.py}}}. I do not think it is a good
 idea to add this new argument to the {{{__init__}}} of the
 {{{TransitiveIdealGraded}}}. I believe the maximal recursion depth should
 be an argument to the iterator method.

 In fact, I started a patch just today in the train to fix stuff about
 {{{TransitiveIdealGraded}}} and {{{TransitiveIdeal}}}. I believe the
 creation of the class {{{TransitiveIdealGraded}}} was a mistake. For the
 same reason, we do not create a class of integers that we are going to
 multiplicate, another class for integers that we are going to add, and
 create a class for integers that we are going to factor. And now adding
 this new argument to the init does not go in the good direction...

 I am goind to upload a patch in a few minutes to make my point more clear.
 Then, I will leave you the choice of using it or not...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14052#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to