#13387: Improve MonoDict and TripleDict data structures
----------------------------------+-----------------------------------------
Reporter: nbruin | Owner: Nils Bruin
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-feature
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nils Bruin | Merged in:
Dependencies: #11521, #12313 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by nbruin):
Replying to [comment:16 SimonKing]:
> What about having different names for the getters and setters (mget/mset
versus tget/tset)? It would avoid the duplication, but would certainly not
be very clean.
I think it's worse than the current situation. The reality is that
`MonoDict` and `TripleDict` only share some data attribute names and a
debug routine. They are each separately implemented. Code sharing is more
inviting bugs due to unintended side-effects of code changes that appear
local (as demonstrated here) than saving work. I think having the classes
independent is better. If it were up to me I'd also make the `Eraser`
classes independent, but that's just a small issue. In the end, both are
just unrolled special cases of `IdKeyDict` (which, as we found, might be a
contender for `TripleDict` but not for `MonoDict`) so we don't have them
for codce cleanliness but for speed.
The patch order is correct, as with the Apply statement before. Note that
the patchbot results page sorts records by the time local to the bot, so
reports are not necessarily in reverse chronological order. It did get a
"tests past" with the current patch sequence.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13387#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
