#14089: Speed improvements in affine crystals and fix of optional doctest
failure
----------------------------------+-----------------------------------------
Reporter: aschilling | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: crystals | Work issues:
Report Upstream: N/A | Reviewers: Nicolas M. Thiery
Authors: Anne Schilling | Merged in:
Dependencies: #14052 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by tscrim):
Sorry, I wasn't specific enough. I meant their creation. I did some tests
now that I have the patch (I wrote that comment last night before you had
posted the patch).
Before patch:
{{{
sage: %time C = KirillovReshetikhinCrystal(['D',4,1], 3,3)
CPU times: user 4.89 s, sys: 0.41 s, total: 5.30 s
Wall time: 5.90 s
}}}
After patch:
{{{
sage: %time C = KirillovReshetikhinCrystal(['D',4,1], 3,3)
CPU times: user 2.11 s, sys: 0.28 s, total: 2.39 s
Wall time: 4.27 s
}}}
So it does help, but they still take a long time to initialize compared to
their counterparts. However this can be an issue for another ticket.
As for the caching of the `index_set()`, the problem is (as you stated)
this returns a mutable list rather than an immutable tuple. I tried doing
this once and from what I recall, the rigged configurations code broke
because it does something like
{{{
I = self.index_set()
I.pop(0)
}}}
which would have to be tweaked to
{{{
I = self.index_set()[1:]
}}}
but IDK if this behavior occurs anywhere else.
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14089#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
