#11696: The libpng12 spkg should also create symbolic links from `libpng.*` for 
its
libraries
-----------------------------------------------------+----------------------
       Reporter:  leif                               |         Owner:  leif     
   
           Type:  defect                             |        Status:  
needs_review
       Priority:  major                              |     Milestone:  sage-5.7 
   
      Component:  packages                           |    Resolution:           
   
       Keywords:  PNG libpng spkg                    |   Work issues:           
   
Report Upstream:  N/A                                |     Reviewers:           
   
        Authors:  Leif Leonhardy, Jean-Pierre Flori  |     Merged in:           
   
   Dependencies:                                     |      Stopgaps:           
   
-----------------------------------------------------+----------------------
Changes (by {'newvalue': u'Leif Leonhardy, Jean-Pierre Flori', 'oldvalue': 
u'Leif Leonhardy'}):

 * cc: kcrisman, dimpase (added)
  * status:  needs_work => needs_review
  * author:  Leif Leonhardy => Leif Leonhardy, Jean-Pierre Flori


Old description:

> Doing so avoids trouble if `pkg-config` isn't available, and packages
> look for just `libpng`.
>
> The header `png.h` is already installed in `$SAGE_LOCAL/include/`, and a
> symbolic link from `$SAGE_LOCAL/lib/pkgconfig/libpng.pc` to the actual
> `libpng12.pc` is also created.
>
> ----
>
> Actually the links (and a compatibility `libpng` shared library)
> '''are''' created by upstream, but `spkg-install` deleted these.
>
> ----
>
> '''New spkg: http://spkg-
> upload.googlecode.com/files/libpng-1.2.35.p4.spkg'''
>
> '''md5sum:''' `3789f82616a101eb1b00f339509f9616  libpng-1.2.35.p4.spkg`
>

> === libpng-1.2.35.p4 (Leif Leonhardy, August 17th 2011) ===
>  * #11696: Do *not* delete symbolic links from `libpng.*` (and the shared
>    library named `libpng.so.*`) in `$SAGE_LOCAL/lib`; see the comment in
>    `spkg-install` for why (cf. also #11686).
>  * Add `-L$SAGE_LOCAL/lib` to `LDFLAGS`, since otherwise Sage's zlib
> won't
>    be used.
>  * Fix order of additions to flags, and don't drop user's settings. (Some
>    might still intentionally get overridden though.)
>  * Use `$MAKE`, but also install serially since this shouldn't take much
>    time and is certainly safer.
>  * Quote also `$UNAME`.

New description:

 Doing so avoids trouble if `pkg-config` isn't available, and packages look
 for just `libpng`.

 The header `png.h` is already installed in `$SAGE_LOCAL/include/`, and a
 symbolic link from `$SAGE_LOCAL/lib/pkgconfig/libpng.pc` to the actual
 `libpng12.pc` is also created.

 ----

 Actually the links (and a compatibility `libpng` shared library) '''are'''
 created by upstream, but `spkg-install` deleted these.

 ----

 Use spkg at:
 http://boxen.math.washington.edu/home/jpflori/libpng-1.2.35.p5.spkg

 ----

 Original changes:
 === libpng-1.2.35.p4 (Leif Leonhardy, August 17th 2011) ===
  * #11696: Do *not* delete symbolic links from `libpng.*` (and the shared
    library named `libpng.so.*`) in `$SAGE_LOCAL/lib`; see the comment in
    `spkg-install` for why (cf. also #11686).
  * Add `-L$SAGE_LOCAL/lib` to `LDFLAGS`, since otherwise Sage's zlib won't
    be used.
  * Fix order of additions to flags, and don't drop user's settings. (Some
    might still intentionally get overridden though.)
  * Use `$MAKE`, but also install serially since this shouldn't take much
    time and is certainly safer.
  * Quote also `$UNAME`.

 Further changes:
  * Let libpng build a correct import on Cygwin using the SYMBOL_PREFIX
 trick, seehttp://old.nabble.com/Fwd%3A---libpng-Bugs-2981656---Import-
 library-definitions-missing-in-Windows-td28130513.html.
  * Further cleanups.

--

Comment:

 I've cleaned up everything, removed commented out code, added the trick
 for Cygwin.
 Needs review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11696#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to