#5180: [with new patch, positive review] Improvements to congruence subgroups
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4.1
Component: modular forms | Keywords: congruence subgroups
---------------------------+------------------------------------------------
Comment(by davidloeffler):
For what it's worth, I'm completely happy with Georg's latest patch; and I
applied patches 0-4 above and all the quaternion patches from #5520 and
#5632 on top of 3.4.1.alpha0 and ran "sage -testall" and there were no
failures. (Except, that is, the unrelated one in
sage/rings/number_field/number_field_ideal_rel that is fixed by #5159.)
Georg's patch doesn't change any actual code other than fixing one line to
restore the exact same behaviour it had before I broke it, so I guess
there's no need to have a separate review. (Michael: please correct me if
I'm wrong -- I've never been very sure about the etiquette of Sage patch
reviewing.) So I'm changing this back to "positive review".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5180#comment:13>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
