#14084: Wrong domain of the fraction field construction functor
------------------------------+---------------------------------------------
Reporter: SimonKing | Owner: roed
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: padics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Julian Rueth
Authors: Simon King | Merged in:
Dependencies: | Stopgaps:
------------------------------+---------------------------------------------
Changes (by SimonKing):
* status: needs_info => needs_review
Comment:
Replying to [comment:27 saraedum]:
> Simon, in {{{local_generic.py}}} you add a category parameter but seem
to ignore it. Was that intended?
No. Originally I thought of a different way to initialise stuff, because I
thought that `LocalGeneric` is the base class of ''both'' power series
rings and p-adic rings. So, I expected that the sub-classes would
eventually like to pass a `category` to the init method of `LocalGeneric`.
But since it is only used for p-adic rings, it isn't needed.
The questions remain:
- ''Should'' power series inherit from `LocalGeneric`? This would be for a
different ticket.
- Since power series do not inherit from `LocalGeneric`, shouldn't the
documentation of local_generic.py be corrected accordingly?
Anyway. I have updated the patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14084#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
