#12415: Update doctesting framework
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
       Reporter:  robertwb                                                      
                                                                                
                                |         Owner:  jdemeyer      
           Type:  enhancement                                                   
                                                                                
                                |        Status:  needs_work    
       Priority:  major                                                         
                                                                                
                                |     Milestone:  sage-5.8      
      Component:  doctest                                                       
                                                                                
                                |    Resolution:                
       Keywords:                                                                
                                                                                
                                |   Work issues:                
Report Upstream:  N/A                                                           
                                                                                
                                |     Reviewers:  Jeroen Demeyer
        Authors:  David Roe, Robert Bradshaw                                    
                                                                                
                                |     Merged in:                
   Dependencies:  #13147,#13146, #13145, #12723, #12392, #12393, #12395, 
#12396, #12397, #12381, #12382, #12383, #12384, #11871, #13195, #13121, #13748, 
#13899, #12719, #5155, #14070, #14079  |      Stopgaps:                
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Comment (by roed):

 > > * Your changes to `sage.calculus.test_sympy` break doctests on my
 machine: they were correct before the change.  Presumably these results
 are system dependent and should be changed somehow.
 > The difference is between plain ASCII characters and some fancy Unicode
 characters for the display. Not sure what to do with this.

 I fixed it by temporarily turning off unicode in pretting printing.  I
 updated the patch with this change.

 > > * I get a bad exit in sage.misc.interpreter at line 132 (in
 `get_test_shell()`):
 > Did you apply #14070?

 Nope: applying #14070 fixed the problem.

 > > * There's still an error in `sagenb.notebook.worksheet` line 196:
 `sagenb.notebook` has no attribute `misc`.  I've seen this before and it
 should be easy to fix.
 > Good, then please fix it.

 Okay, the easy fix I remembered is to add a line to
 sagenb.notebook.worksheet:

 {{{
          EXAMPLES: We test the constructor via an indirect doctest::

              sage: nb =
 sagenb.notebook.notebook.Notebook(tmp_dir()+'.sagenb')
 +            sage: import sagenb.notebook.misc
              sage: sagenb.notebook.misc.notebook = nb
              sage: W = nb.create_new_worksheet('Test with unicode
 ěščřžýáíéďĎ', 'admin')
              sage: W

 }}}

 I haven't made any changes to `sagenb` for a long time.  I assume this
 would require a new spkg?

 > > How is [attachment:12415_review.patch] coming along?
 > I think it works well for normal testing. I still have to think about
 `--debug` and things like `--gdb`.  It seems it will be necessary to have
 a serial mode for example for `--gdb`, so  I have to put that back in.  I
 would also like to force `--serial` when `--debug` is used, mainly to
 simplify the code.

 Makes sense.

 > But first I'm going to look at #14079 on OS X.

 Good luck.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12415#comment:196>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to