#13618: Doctest coverage for rings
------------------------------------+---------------------------------------
       Reporter:  tscrim            |         Owner:  tscrim      
           Type:  enhancement       |        Status:  needs_review
       Priority:  major             |     Milestone:  sage-5.7    
      Component:  doctest           |    Resolution:              
       Keywords:  doctests          |   Work issues:              
Report Upstream:  N/A               |     Reviewers:              
        Authors:  Travis Scrimshaw  |     Merged in:              
   Dependencies:  #13634, #12802    |      Stopgaps:              
------------------------------------+---------------------------------------

Comment (by vbraun):

 I've looked through the other two patches and they look good to me except
 that there is lots of unnecessary whitespace change. This does nothing but
 break other patches on trac. We'll programmatically remove trailing
 whitespace when we change to git. Can you go through them and at least
 remove the patch hunks that do nothing but whitespace change? Like this
 {{{
 [...]
 @@ -359,9 +422,9 @@ class Ideal_generic(MonoidElement):
      def base_ring(self):
          r"""
          Returns the base ring of this ideal.
 -
 +
          EXAMPLES::
 -
 +
              sage: R = ZZ
              sage: I = 3*R; I
              Principal ideal (3) of Integer Ring
 @@ -370,16 +433,16 @@ class Ideal_generic(MonoidElement):
 [...]
 }}}
 Kannappan, are you still reviewing the "real" patch?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13618#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to