#13618: Doctest coverage for rings
------------------------------------+---------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: doctest | Resolution:
Keywords: doctests | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Travis Scrimshaw | Merged in:
Dependencies: #13634, #12802 | Stopgaps:
------------------------------------+---------------------------------------
Comment (by knsam):
Oops! Sorry for the delay!! I had to look through, because reviewing
doctests is new to me. But, I have just finished it!
Here are some trivial comments, rectifying these as necessary should give
this positive review:
1. In `real_double`, `real_mpfr`: It might be nice if we codify the PARI
commands too. For instance, the algorithm for `algebraic_dependence()` and
`algdep()`, we refer to the PARI command `algdep`.
2. In `real_mpfi`: In the method for `str()`, could you please use `\cdot`
instead of `*`?
3. In `real_interval_absolute`: Some docstrings are too short to be
useful; we'd also would have to look into the grammar and codify
appropriate things like self. The example for `upper()` is not formatted
properly. (I'd be totally OK if this goes into another ticket.)
Else, as I said, this is fantastic!
~KnS
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13618#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
