#13605: Partition options and cleanup partitions documentation
------------------------------------------------------+---------------------
Reporter: tscrim | Owner:
sage-combinat
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.8
Component: combinatorics | Resolution:
Keywords: partition, options, output, days45 | Work issues:
Report Upstream: N/A | Reviewers: Andew
Mathas
Authors: Travis Scrimshaw | Merged in:
Dependencies: #14065 #6495 #14063 #13688 | Stopgaps:
------------------------------------------------------+---------------------
Comment (by nthiery):
Hi!
I went through roughly the first half of the patch. Altogether it's good!
I just posted a reviewer's patch on the patch server, mostly to follow the
guidelines of the developpers manual. Please have a look at my changes;
similar ones probably need to be done in the rest of the patch. Note that
I also did a couple changes directly in Travis's version of the patch on
the queue.
One thing that would need a small clarification: there is some duplication
between the documentation of the "global_options" module and the
"GlobalOptions" class. That's not necessarily bad since they can serve
different roles (tutorial/reference). But this should be stated explicitly
with appropriate cross references.
Thanks!
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13605#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
