#14184: Fix # optional tags
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: mvngu
Type: defect | Status: new
Priority: major | Milestone: sage-5.8
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by kcrisman):
Isn't this exactly the kind of huge intrusive patch we've been trying to
avoid? ;-) That said, it would be really nice to have standardization
for people to look at, so I'm not opposed to this.
Stuff to fix and/or think about doing as long as this ticket is opened.
* The sage/coding/guava.py should have the same message as the ones in
sage/coding/code_bounds.py and sage/coding/linear_code.py
* `# long time; optional - internet ` and in another place, reversed - I
assume that won't matter, but just asking in case
* `# optional - database_hohel` - I don't know of a Hohel in Sage
development, but I bet
[http://sagemath.org/packages/optional/database_kohel-20060803.spkg the
database_kohel spkg] is what is meant :-)
* Did we change the `convert` ones to `ImageMagick`, or vice versa?
Anyway, that should be standardized if it wasn't already elsewhere (this
feels familiar)
* I'm not sure why something can depend on dot2tex but not graphviz, and
even more weirdly, graphviz is experimental, but not dot2tex ?!?!? Though
I guess it is okay...
* sometimes `octave`, sometimes `Octave` - does capitalization matter?
Same with `Axiom`.
* `somewhat random` - is that an official designation?
* `< 1/100th of a second ` - well, I guess it might be! I guess we can
leave that.
* What is the `time` command? The one that we always have? I'm confused
here.
{{{
sage: q = qsieve(n, block=False, time=True) # optional - time
}}}
* The `sage/lfunctions/sympow.py` test seems ... odd. Should it instead
be long test? Note that the previous command just says optional, with no
indication of why.
* `# optional - FES, random` - does it matter if random is before or
after? I would think this is going to look for the `random` spkg. Same
with `# optional; randomly growing. `
Otherwise looks good - I did look at all of them by hand, not the script.
Though obviously I am not going to try to test all of these optional tests
by hand.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14184#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
