#14184: Fix # optional tags
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: mvngu
Type: defect | Status: new
Priority: major | Milestone: sage-5.8
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by jdemeyer):
Replying to [comment:7 kcrisman]:
> Isn't this exactly the kind of huge intrusive patch we've been trying to
avoid? ;-)
Not really. Huge intrusive patches are okay as long as they serve a
purpose. Removing whitespace all over the place doesn't serve a purpose,
this patch certainly does.
This patch is mainly motivated by #12415, which has different (more
strict) parsing for `# optional`, leading to less false positives (but
also less true positives, hence this patch).
> * The sage/coding/guava.py should have the same message as the ones in
sage/coding/code_bounds.py and sage/coding/linear_code.py
OK, I'll have a look.
> * `# long time; optional - internet ` and in another place, reversed -
I assume that won't matter, but just asking in case
Doesn't matter.
> * `# optional - database_hohel` - I don't know of a Hohel in Sage
development, but I bet
[http://sagemath.org/packages/optional/database_kohel-20060803.spkg the
database_kohel spkg] is what is meant :-)
OK, so that's a typo.
> * Did we change the `convert` ones to `ImageMagick`, or vice versa?
Anyway, that should be standardized if it wasn't already elsewhere (this
feels familiar)
I have no idea.
> * I'm not sure why something can depend on dot2tex but not graphviz,
and even more weirdly, graphviz is experimental, but not dot2tex ?!?!?
Though I guess it is okay...
I have no idea what these packages are.
> * sometimes `octave`, sometimes `Octave` - does capitalization matter?
Same with `Axiom`.
OK, changing to all lowercase.
> * `somewhat random` - is that an official designation?
The doctester looks for "random", so it will be recognized. I think it's
fine.
> * `< 1/100th of a second ` - well, I guess it might be! I guess we can
leave that.
This can be seen as "just a comment" without further meaning.
> * What is the `time` command? The one that we always have? I'm
confused here.
I have no idea.
> * The `sage/lfunctions/sympow.py` test seems ... odd. Should it
instead be long test? Note that the previous command just says optional,
with no indication of why.
True, it's odd. I think it means that you need to run `sympow` first to
create some tables, but I don't know more.
> * `# optional - FES, random` - does it matter if random is before or
after? I would think this is going to look for the `random` spkg. Same
with `# optional; randomly growing. `
At least with the ''new'' doctester (which is what we're aiming for),
{{{optional - FES, random}}} will only require {{{FES}}}.
> Though obviously I am not going to try to test all of these optional
tests by hand.
That is also most certainly not the point of this ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14184#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
