#13432: add sage/env.py and fix many inappropriate references to SAGE_ROOT
-----------------------------------+----------------------------------------
Reporter: rohana | Owner: jason
Type: task | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: R. Andrew Ohana | Merged in:
Dependencies: #13123, #13348 | Stopgaps:
-----------------------------------+----------------------------------------
Comment (by fbissey):
Replying to [comment:18 rohana]:
> Replying to [comment:17 fbissey]:
> > sage/sandpiles/sandpile.py you have
> > {{{
> > SAGE_ROOT = os.environ['SAGE_ROOT']
> > path_to_zsolve = SAGE_ROOT+'/local/bin/'
> > }}}
> > becoming
> > {{{
> > path_to_zsolve = os.path.join(SAGE_LOCAL,'bin','zsolve')
> > }}}
> > Is it correcting a bug as well?
>
> No, if you look a little further down, I change a
`path_to_zsolve+'zsolve'` to just `path_to_zsolve` -- this is a little
cleaner, and it removes the string arithmetic that should be
`os.path.join`'s.
I missed that line.
Is the replacement of SAGE_INC in setup.py (well spotted the one where it
is still SAGE_LOCAL/include) by CPATH really necessary? That's the only
place CPATH is used and you don't use it in module_list.py anyway.
Apart from this I am positive that it should go in while it is easy to
apply. We may do some more work on this later.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13432#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
