#13432: add sage/env.py and fix many inappropriate references to SAGE_ROOT
-----------------------------------+----------------------------------------
       Reporter:  rohana           |         Owner:  jason          
           Type:  task             |        Status:  positive_review
       Priority:  major            |     Milestone:  sage-5.9       
      Component:  misc             |    Resolution:                 
       Keywords:                   |   Work issues:                 
Report Upstream:  N/A              |     Reviewers:  François Bissey
        Authors:  R. Andrew Ohana  |     Merged in:                 
   Dependencies:  #13123, #13348   |      Stopgaps:                 
-----------------------------------+----------------------------------------
Changes (by rohana):

  * reviewer:  => François Bissey


Old description:

> There are many places within the Sage library that make explicit
> references to `SAGE_ROOT`, when `SAGE_LOCAL`, `SAGE_DATA`, etc. are more
> appropriate. These references assume a particular directory structure
> which unnecessarily break various components when using a different
> directory structure (i.e. transitioning to git or sage-on-gentoo). This
> ticket aims to correct many of these references.
>
> This ticket also adds `sage.env` as a place to keep global used Sage
> variables (these currently live in `sage.misc.misc`). Currently this file
> does little more than separate out some of these variables, but the
> intent is to provide a dedicated place in python for determining the
> environment for the Sage library (this will eventually need to be
> independent of `sage-env` if we are ever to truly transition to
> argparse).
>
> Followup: #14226.
>
> '''Installation Instructions''':
>  * apply attachment:trac13432.patch to the sage library

New description:

 There are many places within the Sage library that make explicit
 references to `SAGE_ROOT`, when `SAGE_LOCAL`, `SAGE_DATA`, etc. are more
 appropriate. These references assume a particular directory structure
 which unnecessarily break various components when using a different
 directory structure (i.e. transitioning to git or sage-on-gentoo). This
 ticket aims to correct many of these references.

 This ticket also adds `sage.env` as a place to keep global used Sage
 variables (these currently live in `sage.misc.misc`). Currently this file
 does little more than separate out some of these variables, but the intent
 is to provide a dedicated place in python for determining the environment
 for the Sage library (this will eventually need to be independent of
 `sage-env` if we are ever to truly transition to argparse).

 Followup: #14226.

 '''Installation Instructions''':
  * apply attachment:trac13432.patch to the sage library
  * apply attachment:trac13432_root.patch to the root repository

--

Comment:

 Replying to [comment:27 fbissey]:
 > I was concerned that not putting SAGE_INC would break some upgrades.

 Good point, I think Jeroen tries to make sure that all versions back to
 4.8 can still upgrade. This should still work even for those versions
 since the sage library implicitly depends on SAGE_ROOT_REPO, but just to
 be sure, I've added a tiny patch to the root repository to make this
 dependency explicit.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13432#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to