#14226: add SAGE_INST environment variable
-----------------------------------+----------------------------------------
       Reporter:  rohana           |         Owner:  jason                      
                                                           
           Type:  enhancement      |        Status:  needs_work                 
                                                           
       Priority:  major            |     Milestone:  sage-5.9                   
                                                           
      Component:  misc             |    Resolution:                             
                                                           
       Keywords:                   |   Work issues:  Fix files in `local/bin/` 
(scripts repo) as well.  Probably document the new variable.
Report Upstream:  N/A              |     Reviewers:  Robert Bradshaw, Leif 
Leonhardy                                                       
        Authors:  R. Andrew Ohana  |     Merged in:                             
                                                           
   Dependencies:  #13432           |      Stopgaps:                             
                                                           
-----------------------------------+----------------------------------------
Changes (by leif):

  * status:  positive_review => needs_work
  * reviewer:  => Robert Bradshaw, Leif Leonhardy
  * work_issues:  => Fix files in `local/bin/` (scripts repo) as well.
                  Probably document the new variable.


Comment:

 There are also instances in the Sage scripts repository
 (`$SAGE_ROOT/local/bin/`) which have to get fixed, e.g. in
 `sage-update`:
 {{{
 #!python
     installed = set(os.listdir(os.path.join(SPKG_ROOT, "installed")))
 }}}

 Same in `sage-list-packages`:
 {{{
 #!python
 try:
      installed = set(os.listdir(os.path.join(SPKG_ROOT, 'installed')))
 except OSError:
      installed = set([])
 }}}

 There are presumably even more, but simple grepping yields false positives
 as well; I've found:
 {{{
 local/bin/sage-bdist:   cp $CP_OPT installed "$TMP/$PKGDIR/"

 local/bin/sage-list-packages:     installed =
 set(os.listdir(os.path.join(SPKG_ROOT, 'installed')))

 local/bin/sage-make_devel_packages:SPKG_INST="$SAGE_ROOT"/spkg/installed/

 local/bin/sage-update:    installed =
 set(os.listdir(os.path.join(SPKG_ROOT, "installed")))
 }}}

 Looking at those, isn't `SPKG_INST` (or `SAGE_SPKG_INST`) a better name?
 ;-)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14226#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to