#14146: Warn when creating number fields with non-monic-integral polynomials
---------------------------------+------------------------------------------
Reporter: Bouillaguet | Owner: davidloeffler
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.8
Component: number fields | Resolution:
Keywords: pari | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by mstreng):
Thanks Charles, this is very good to have!
A comment and a question:
* The doctest with output "doctest:311" will likely break later on. Better
is to write "doctest:..." in the output.
* Why an error in one situation and a warning in another? Why not a
warning in both? You are disallowing some functionality with the error, as
seen from the following in an unpatched Sage 5.7:
{{{
sage: k.<i> = NumberField(x^2+1)
sage: l.<b> = k.extension(5*x^2 + 3)
sage: c = b + b
sage: c^2 == -12/5
True
sage: c^2 == b
False
}}}
* There is a discrepancy between the absolute and the relative case. With
your patch on Sage 5.7:
{{{
sage: k.<a> = NumberField(5*x^2+3)
NotImplementedError: number fields for non-monic polynomials not yet
implemented.
sage: k.<i> = NumberField(x^2+1)
sage: l.<b> = k.extension(5*x^2+3)
ValueError: the polynomial must be monic
}}}
I prefer the `NotImplementedError`, and it would be good to add a
reference to #252 to that error message.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14146#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
