#13249: Volume computation of polyhedra
------------------------------------------------------------------+---------
Reporter: mhampton |
Owner: mhampton
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.9
Component: geometry |
Resolution:
Keywords: polyhedra, lrs_volume, geometry | Work
issues:
Report Upstream: N/A |
Reviewers:
Authors: Marshall Hampton, Franco Saliola, Volker Braun | Merged
in:
Dependencies: #14184 |
Stopgaps:
------------------------------------------------------------------+---------
Old description:
> The recent changes to the geometry/polyhedra module broke support for the
> lrs_volume() method of the Polyhedron class. This is not tested usually
> because it relies on the lrs optional package. The fix is very simple,
> just a couple of imports needed to be added.
>
> While we are at it, implement the native volume computation whose bits
> and pieces (triangulation and volume of simplices) have been around for a
> while but haven't been hooked up.
>
> Apply:
> * [attachment:trac_13249_vb.patch]
> * [attachment:trac_13249_volume.patch]
New description:
The recent changes to the geometry/polyhedra module broke support for the
lrs_volume() method of the Polyhedron class. This is not tested usually
because it relies on the lrs optional package. The fix is very simple,
just a couple of imports needed to be added.
While we are at it, implement the native volume computation whose bits and
pieces (triangulation and volume of simplices) have been around for a
while but haven't been hooked up.
Apply:
* [attachment:trac_13249_vb.patch]
* [attachment:trac_13249_volume.patch]
* [attachment:trac_13249-review-fc.patch]
--
Comment (by chapoton):
I have made a small review patch, including a clean up of the unused or
missing import statements (found using pyflakes)
If you are happy with my review patch, and when the bot turns green again,
you can set a positive review
for the bot:
Apply trac_13249_vb.patch trac_13249_volume.patch trac_13249-review-
fc.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13249#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
