#9670: Bring probability/random_variable.py to 100% coverage
---------------------------------+------------------------------------------
       Reporter:  kcrisman       |         Owner:  mvngu       
           Type:  enhancement    |        Status:  needs_review
       Priority:  major          |     Milestone:  sage-5.9    
      Component:  documentation  |    Resolution:              
       Keywords:                 |   Work issues:              
Report Upstream:  N/A            |     Reviewers:              
        Authors:                 |     Merged in:              
   Dependencies:                 |      Stopgaps:              
---------------------------------+------------------------------------------
Changes (by rohana):

  * status:  new => needs_review


Comment:

 A few comments to start with:
 1. the first sentence of the commit message should be short, if more info
 is needed add two new lines before the rest of the commit (so that there
 is an empty line between the first sentence and the rest of the commit
 message)
 1. every python function needs to have tests, even hidden functions. So
 for things like multiplication, add tests to make sure that A*B is what
 you expect it to be
 1. (not strictly necessary) for sake of readability, it would help if you
 had an empty line before each function definition

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9670#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to