#5685: [with patch, needs review] enhanced nth_root in ZZ and QQ and related
utilities
------------------------------+---------------------------------------------
Reporter: cremona | Owner: somebody
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.2
Component: basic arithmetic | Keywords: nth root rational integer
------------------------------+---------------------------------------------
Comment(by was):
* The new code you added to extended_integer_ring.py is this:
{{{
199 def nth_root(self, n, truncate_mode=0):
200 temp = Integer.nth_root(self, n, truncate_mode)
201 if truncate_mode:
202 return self.parent()(temp[0]), temp[1]
}}}
There is no documentation or docstring or doctests.
* In integer.pyx:
{{{
def nth_root(self, int n, int truncate_mode=0):
}}}
Should the truncate_mode be of type bint (=boolean int)?
Otherwise, I like this patch.
-- William
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5685#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
