#14192: Infinity crystal of tableaux
---------------------------------------------------+------------------------
Reporter: bsalisbury1 | Owner:
sage-combinat
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.9
Component: combinatorics | Resolution:
Keywords: crystal, tableaux | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Ben Salisbury, Travis Scrimshaw | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------------+------------------------
Comment (by aschilling):
Hi Ben and Travis,
Thanks for your work on this. Here are a couple of comments:
- Could you please fold the two patches? That makes it easier to review!
- In the title "`\mathcal{B}(\infty)` Crystals of Tableaux" specify the
types for which this works.
- There are trailing white spaces. Please remove them!
- Why don't you put the Element class into the parent class (by
indentation)? See for example how this is done in Littelmann paths. Also,
the parent class should come first!
- In string_parameters, the Examples are indented wrongly!
Please make these changes and then I'll look again!
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14192#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
