#14406: Various prereq fixes
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: drkirkby
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.9
Component: porting | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by jpflori):
In the prereq install script, the Solaris part could be a little bit
polished.
The first sentence includes a disturbing also:
{{{
You MUST also use the GNU version of tar...
}}}
whereas nothing precedes it.
I don't really like the fact that both tar and make are tested together in
the constructions
{{{
if [ -f "/usr/sfw/bin/gtar" ] && [ -f "/usr/sfw/bin/gmake" ] ; then
}}}
The only advantage of doing this is to easily suggest to do
{{{
echo "$ mkdir \$HOME/bins-for-sage"
echo "$ cp /usr/sfw/bin/gmake \$HOME/bins-for-sage/make"
echo "$ cp /usr/sfw/bin/gtar \$HOME/bins-for-sage/tar"
echo "$ export PATH=\$HOME/bins-for-sage:\$PATH"
}}}
I think we'd better split the two tests, i.e. only check for tar in the
tar part and for make in the make part.
At worst, a naive user will have to run make twice before it passes the
prereq checks and will have twice $HAME\bins-for-sage in its PATH.
There are also ugly double spaces before "&&" on the (new) lines 132 and
165 :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14406#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
