#5673: [with patch, positive review] Enhanced handling of elliptic curve twists
---------------------------+------------------------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.2
Component: number theory | Keywords: elliptic curve twist
---------------------------+------------------------------------------------
Comment(by cremona):
Replying to [comment:3 robertwb]:
> The only suggestion I have is that it might be better to return
{{{False}}} rather than {{{0}}} for non-twists.
I did that since I wanted the return type to be the same whatever. But
that stopped me doing the right thing in char. 2 when twists are additive
(so a twist parameter of 0 means isomorphic).
It's the usual thing: ideally I would want to return either (True, param)
or False, but that is not allowed in Sage. We could go for a more
complicated function which by default just returns True/False, or if an
optional parameter "return_parameter" is set to True returns a tuple
either (True, param) or (False,).
One advantage of the current setup is that if you do not need the
parameter you can use the output as if it were a bool with 0 converting to
False. I think.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5673#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
