#14489: _S_class_group_and_units is mathematically incorrect
---------------------------------+------------------------------------------
Reporter: robharron | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.10
Component: number fields | Resolution:
Keywords: S-class group | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Robert Harron | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by tscrim):
Some things on the docstrings and code from looking at the patch file:
- I think it would be better to put the import of `prod` and `Matrix` at
the module level since they are imported at startup anyways. This will
have a small, but noticable effect on the speed.
- Could you add a doctest to check the output when `len(S) == 0` and/or
`J.is_principle()` is true (if these tests aren't already present)?
- Could you indent the block starting at line 3486 by 2 spaces (the first
char should be in-line with the first non-whitespace character after the
bullet/dash)?
I can't do the mathematical review.
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14489#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
