#14489: _S_class_group_and_units is mathematically incorrect
---------------------------------+------------------------------------------
       Reporter:  robharron      |         Owner:  davidloeffler
           Type:  defect         |        Status:  needs_review 
       Priority:  critical       |     Milestone:  sage-5.10    
      Component:  number fields  |    Resolution:               
       Keywords:  S-class group  |   Work issues:               
Report Upstream:  N/A            |     Reviewers:               
        Authors:  Robert Harron  |     Merged in:               
   Dependencies:                 |      Stopgaps:               
---------------------------------+------------------------------------------

Comment (by robharron):

 Ugh, my comment was just swallowed by trac.

 Try again, but quicker: I figured out the problems.

 Line 984: Both answers are correct. At some point, my code returns -pr
 whereas the old code returns pr. The discrepancy between the doctest
 illustrates the subtlety in this: if I open sage and enter all the
 commands in the doctest for S_class_group in order, then I get the same
 answer the doctest got; whereas just entering the commands from line 981
 to 984 gives the answer the doctest expected. Anyway, I'm just going to
 update the doctest. (Is there an issue with the difference between 32 and
 64 bit, I'm on a 64 bit machine).

 Line 990: The expected answer is incorrect. The ideal in question when
 squared is not principal (in fact, the line 984 example says that the
 order is 6 not 2). So, I'll update the doctest with the new answer.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14489#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to