#14501: Fix memory allocation problems in data_structures_pyx.pxi
---------------------------------+------------------------------------------
Reporter: dcoudert | Owner: joyner
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: group theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: David Coudert | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ncohen):
Yoooooooooooo !
Well, what you do seems mostly harmless (though
``sage_free(SC.generators[i])`` is not indented correctly) but if it
changes nothing ?...
Moving the two assignment can avoid a segfault alright, replacing a malloc
by a calloc is unnecessary unless proven otherwise, and splitting a loop
into two may also be unnecessary if the two vectors are only allocated
together (and checked at that time).
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14501#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
