#14502: Improvements of hyperbolicity procedures
---------------------------------+------------------------------------------
       Reporter:  dcoudert       |         Owner:  jason, ncohen, rlm
           Type:  enhancement    |        Status:  needs_work        
       Priority:  major          |     Milestone:  sage-5.10         
      Component:  graph theory   |    Resolution:                    
       Keywords:                 |   Work issues:                    
Report Upstream:  N/A            |     Reviewers:                    
        Authors:  David Coudert  |     Merged in:                    
   Dependencies:                 |      Stopgaps:                    
---------------------------------+------------------------------------------
Changes (by ncohen):

  * status:  needs_review => needs_work


Comment:

 Yoooooooooooooo !

 * You probably want to sort the vertices .... in the other direction.
 * I am not sure that the ordering of the degrees in `.degree()` is the
 same as `g.vertices()`. You probably want to use `g.degree(labels =True)`.
 * seen is a set, not a dictionary
 * Why do you need 32 bits for each vertex of a pair ? The algorithm uses
 distance_all_pairs which does not work when the vertices cannot be stored
 on short int.
 * Why do you remove all this `h>=2` code ?
 * Why do you replace a call to `relabel` with a call to `my_subgraph` ? Is
 it because `.relabel()` is too slow ? The speed of this function has been
 changed *a LOT* by #14000. You can also set `check_input=False` if you are
 sure that there is no problem with the new labels.

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14502#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to