#14527: chromatic_polynomial - fixed memory leak and added new test cases
--------------------------------+-------------------------------------------
Reporter: azi | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Old description:
> This patch fixes a minor memory leak in the chromatic polynomial code. It
> appears to me that the mpz variables should be freed at the end of the
> function.
>
> I have also added additional tests.
>
> The code appears not to be practical for graphs of order +15. I am
> wondering if we could gain some speed by using memoization. It would
> complicate the code quite a bit but it might be a drastic improvement!
New description:
This patch fixes a minor memory leak in the chromatic polynomial code. It
appears to me that the mpz variables should be freed at the end of the
function.
I have also added additional tests.
The code appears not to be practical for graphs of order +15. I am
wondering if we could gain some speed by using memoization. It would
complicate the code quite a bit but it might be a drastic improvement!
* [attachment:trac_14527_chrompoly.patch]
* [attachment:trac_14527_chrompoly2.patch]
--
Comment (by ncohen):
Okayyyyy, thanks ! `:-)`
By the way, when there are several patches on a ticket, Jeroen likes to
have a message in the trac's description saying how they are to be
applied. Like the one I just added.
Have fuuuuuuuuuuuuuuun !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14527#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
