#14266: Pretty Console Output --> ascii art
---------------------------------------+------------------------------------
Reporter: elixyre | Owner: was
Type: task | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: user interface | Resolution:
Keywords: ascii-art | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jean-Baptiste Priez | Merged in:
Dependencies: | Stopgaps:
---------------------------------------+------------------------------------
Comment (by elixyre):
Replying to [comment:27 tscrim]:
> A few more things:
>
> * There's still a few functions without doctests (this includes
`_private_methods`).
I added some test... but sometime when the method it just a capsule:
{{{
def meth(self):
return self.other_meth()
}}}
or something similar, I just put `see :meth:other_meth`.
> * Bullet points needs a blankline before them, in particular, the
authors block should be
> {{{
> AUTHORS:
>
> - Jean-Baptiste ...
> }}}
I think it's okay now.
> * Any block should be in all caps, such as `EXAMPLES::`
I hope it's okay too.
> * I'd prefer using triple double-quotes rather than triple single-quotes
for consistancy, but this is not a big issue
I try to do that when it's not my files and I think (but I don't verify)
it is consistant in mine.
> * Your commit message should have the description on the first line:
> {{{
> New version of ascii art module and magic function associated.
> }}}
In the last patch I put that and this one must work on 5.9.
Thanks,
Jean-Baptiste
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14266#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
