#14266: Pretty Console Output --> ascii art
---------------------------------------+------------------------------------
Reporter: elixyre | Owner: was
Type: task | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: user interface | Resolution:
Keywords: ascii-art | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jean-Baptiste Priez | Merged in:
Dependencies: | Stopgaps:
---------------------------------------+------------------------------------
Comment (by tscrim):
Replying to [comment:29 elixyre]:
> Replying to [comment:27 tscrim]:
> > A few more things:
> >
> > * There's still a few functions without doctests (this includes
`_private_methods`).
>
> I added some test... but sometime when the method it just a capsule:
> {{{
> def meth(self):
> return self.other_meth()
> }}}
> or something similar, I just put `see :meth:other_meth`.
The need doc''tests'' not just docstings (there are still non-trivial
methods without tests). However if they are simple wrappers like that,
just make it an alias:
{{{
other_meth = meth
}}}
> > * I'd prefer using triple double-quotes rather than triple single-
quotes for consistency, but this is not a big issue
> I try to do that when it's not my files and I think (but I don't verify)
it is consistent in mine.
This is not done in other files you've modified (ex. `tableau.py`), and
again, to be consistent with the project as whole, I would recommended
using double quotes. However in new files you've created, this is a very
minor issue to me (i.e. I won't let it hold up a positive review).
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14266#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
