#14532: Symplectic graphs
---------------------------------+------------------------------------------
       Reporter:  ncohen         |         Owner:  jason, ncohen, rlm
           Type:  enhancement    |        Status:  needs_review      
       Priority:  major          |     Milestone:  sage-5.10         
      Component:  graph theory   |    Resolution:                    
       Keywords:                 |   Work issues:                    
Report Upstream:  N/A            |     Reviewers:                    
        Authors:  Nathann Cohen  |     Merged in:                    
   Dependencies:                 |      Stopgaps:                    
---------------------------------+------------------------------------------

Comment (by ncohen):

 Helloooooooooooooo !!

 > Sry for comming back at you so late. I had some other stuff lately!

 Come on, I am already very thankful that you take the time to review these
 patches !!!

 > 1. Maybe we should check if d is even and also nonzero (perhaps >= 2)
 since that is also a invalid parameter.

 Done

 > 2. I would change the line
 > {{{
 >  Graph([map(tuple,PV), lambda x,y:V(x)*(M*V(y)) == 0], loops = False)
 > }}} to
 >
 > {{{
 > {{{
 >  Graph((map(tuple,PV), lambda x,y:V(x)*(M*V(y)) == 0), loops = False)
 > }}}
 > }}}
 >
 > which should be 2x faster.

 `O_o`

 Here is what I get when I change it :
 {{{
 sage: graphs.SymplecticGraph(4,4)
 ...
 NetworkXError: Input is not a known data type for conversion.
 }}}

 But what do you think it should do, and why do you think that it should be
 2x faster ? `O_o`

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14532#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to